cheapnud/CheapShotcutRandomizer
Watch
1
0
Fork
You've already forked CheapShotcutRandomizer
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Use CheapAvaloniaBlazor Velopack integration, update packages #24

Merged
cheapnud merged 1 commit from d/velopack-lib into master 2026-08-22 11:36:32 +00:00
Conversation 1 Commits 1 Files changed 8 +25 -98
cheapnud commented 2026-08-22 11:34:55 +00:00
Owner
Copy link
No description provided.
Use CheapAvaloniaBlazor's Velopack integration, update packages
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 14s
Details
Build & Test / Build and Test (pull_request) Successful in 25s
Details
20d739fbc4 
Replace the local UpdateService with the library's WithVelopackUpdates and
IUpdateService (added in 3.3.0), dropping the direct Velopack reference.
Update all NuGet packages; xunit.v3 4.0 moves tests onto
Microsoft.Testing.Platform, so CI runs the test executable directly.
forgejo-actions commented 2026-08-22 11:35:08 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary
    Migrates Velopack auto-update logic from a local UpdateService into the CheapAvaloniaBlazor library via WithVelopackUpdates()/IUpdateService, bumps packages, and switches tests to xunit.v3 4.0 on Microsoft.Testing.Platform.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean removal of duplicated infrastructure by delegating to the shared library.

  3. Issues

🟢 Program.cs — The update endpoint URL is a hardcoded LAN IP (line with WithVelopackUpdates(...)). This was already hardcoded before, so not a regression, but consider making it configurable.

🟢 MainLayout.razor — Removing the explicit CheckAndDownloadAsync() call assumes WithVelopackUpdates reliably triggers background check+download. Verify the library actually starts this automatically, otherwise updates silently never fire. Not verifiable from this diff.

  1. Verdict: APPROVE

Mechanical, well-scoped migration. Just confirm WithVelopackUpdates genuinely runs the background check on startup (previously done manually in OnInitialized), and that Velopack's install/update hooks still execute correctly now that the explicit VelopackApp.Build().Run() is gone and handled by the library.

📊 Tokens: 6162 input + 473 output | 💰 Cost: ~$0.0426
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Migrates Velopack auto-update logic from a local `UpdateService` into the CheapAvaloniaBlazor library via `WithVelopackUpdates()`/`IUpdateService`, bumps packages, and switches tests to xunit.v3 4.0 on Microsoft.Testing.Platform. 2. **Code Quality** ⭐⭐⭐⭐☆ Clean removal of duplicated infrastructure by delegating to the shared library. 3. **Issues** 🟢 Program.cs — The update endpoint URL is a hardcoded LAN IP (line with `WithVelopackUpdates(...)`). This was already hardcoded before, so not a regression, but consider making it configurable. 🟢 MainLayout.razor — Removing the explicit `CheckAndDownloadAsync()` call assumes `WithVelopackUpdates` reliably triggers background check+download. Verify the library actually starts this automatically, otherwise updates silently never fire. Not verifiable from this diff. 4. **Verdict**: **APPROVE** Mechanical, well-scoped migration. Just confirm `WithVelopackUpdates` genuinely runs the background check on startup (previously done manually in `OnInitialized`), and that Velopack's install/update hooks still execute correctly now that the explicit `VelopackApp.Build().Run()` is gone and handled by the library. --- 📊 **Tokens**: 6162 input + 473 output | 💰 **Cost**: ~$0.0426 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit da814f90e1 into master 2026-08-22 11:36:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapShotcutRandomizer!24
No description provided.