cheapnud/CheapShotcutRandomizer
Watch
1
0
Fork
You've already forked CheapShotcutRandomizer
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Move the hardware capabilities panel to Settings #14

Merged
cheapnud merged 1 commit from d/hw-panel-to-settings into master 2026-08-16 02:20:09 +00:00
Conversation 1 Commits 1 Files changed 3 +20 -65
cheapnud commented 2026-08-16 02:19:04 +00:00
Owner
Copy link

It is a read-only info panel, so it joins the other system info on the Settings page and the queue page keeps only queue actions. Also fixes the stale Add Job button reference in the empty-state text.

It is a read-only info panel, so it joins the other system info on the Settings page and the queue page keeps only queue actions. Also fixes the stale Add Job button reference in the empty-state text.
move hardware capabilities panel from the render queue to settings
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 19s
Details
Build & Test / Build and Test (pull_request) Successful in 27s
Details
755e7b2979
forgejo-actions commented 2026-08-16 02:19:22 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary
    Moves the read-only hardware capabilities panel from the Render Queue page to Settings and fixes stale button text in the empty-state message.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean removal of unused state/injection from RenderQueue, and tests were properly updated to match the new behavior.

  3. Issues

🟢 Settings.razor — DetectHardwareAsync() runs sequentially after other init in OnInitializedAsync, whereas RenderQueue previously parallelized detection. This slightly increases Settings page load time but is not a correctness problem.

  1. Verdict: APPROVE

Confirm HardwareInfoCard and HardwareCapabilities are still reachable via existing @using directives in Settings.razor (they appear to be, given the shared media namespaces).

📊 Tokens: 3929 input + 294 output | 💰 Cost: ~$0.0270
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Moves the read-only hardware capabilities panel from the Render Queue page to Settings and fixes stale button text in the empty-state message. 2. **Code Quality** ⭐⭐⭐⭐☆ Clean removal of unused state/injection from RenderQueue, and tests were properly updated to match the new behavior. 3. **Issues** 🟢 Settings.razor — `DetectHardwareAsync()` runs sequentially after other init in `OnInitializedAsync`, whereas RenderQueue previously parallelized detection. This slightly increases Settings page load time but is not a correctness problem. 4. **Verdict**: **APPROVE** Confirm `HardwareInfoCard` and `HardwareCapabilities` are still reachable via existing `@using` directives in Settings.razor (they appear to be, given the shared media namespaces). --- 📊 **Tokens**: 3929 input + 294 output | 💰 **Cost**: ~$0.0270 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit 2b21d6a4f0 into master 2026-08-16 02:20:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapShotcutRandomizer!14
No description provided.