cheapnud/CheapShotcutRandomizer
Watch
1
0
Fork
You've already forked CheapShotcutRandomizer
 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Searchable preset picker with recommended presets on top #13

Merged
cheapnud merged 1 commit from d/preset-autocomplete into master 2026-08-16 02:16:10 +00:00
Conversation 1 Commits 1 Files changed 1 +70 -21
cheapnud commented 2026-08-16 02:15:09 +00:00
Owner
Copy link

The 100-entry preset dropdown becomes a type-ahead autocomplete with a handful of recommended presets (starred) floated to the top, empty meaning custom manual settings. Detected hardware encoders also move above the CPU entries in the encoder list so NVENC is no longer hiding at the bottom.

The 100-entry preset dropdown becomes a type-ahead autocomplete with a handful of recommended presets (starred) floated to the top, empty meaning custom manual settings. Detected hardware encoders also move above the CPU entries in the encoder list so NVENC is no longer hiding at the bottom.
preset picker becomes an autocomplete with recommended presets on top; hardware encoders float above cpu entries
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 13s
Details
Build & Test / Build and Test (pull_request) Successful in 33s
Details
8d713054bb
forgejo-actions commented 2026-08-16 02:15:21 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary: Converts the preset dropdown to a searchable autocomplete with recommended presets pinned on top, and reorders the encoder list to surface hardware encoders first.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean, readable change; ordering logic and recommended-preset handling are well done.

  3. Issues

🟡 AddRenderJob.razor — SearchPresets ignores recommended ordering when searching. Filtered matches derives from _presets which is already ordered, so this is fine — no issue. (Withdrawn.)

🟢 AddRenderJob.razor — ToStringFunc="@(preset => preset?.DisplayName)" returns null for a null preset. MudAutocomplete generally tolerates this, but if DisplayName can be null for a real preset the display may break. Low risk; verify DisplayName is always non-null.

  1. Verdict: APPROVE

Solid, self-contained change with no real bugs. The SearchFunc correctly preserves the pre-sorted order of _presets, and the recommended-first sorting is handled once at load time.

📊 Tokens: 3397 input + 394 output | 💰 Cost: ~$0.0268
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary**: Converts the preset dropdown to a searchable autocomplete with recommended presets pinned on top, and reorders the encoder list to surface hardware encoders first. 2. **Code Quality** ⭐⭐⭐⭐☆ Clean, readable change; ordering logic and recommended-preset handling are well done. 3. **Issues** 🟡 AddRenderJob.razor — `SearchPresets` ignores recommended ordering when searching. Filtered `matches` derives from `_presets` which is already ordered, so this is fine — no issue. (Withdrawn.) 🟢 AddRenderJob.razor — `ToStringFunc="@(preset => preset?.DisplayName)"` returns `null` for a null preset. MudAutocomplete generally tolerates this, but if `DisplayName` can be null for a real preset the display may break. Low risk; verify `DisplayName` is always non-null. 4. **Verdict**: **APPROVE** Solid, self-contained change with no real bugs. The `SearchFunc` correctly preserves the pre-sorted order of `_presets`, and the recommended-first sorting is handled once at load time. --- 📊 **Tokens**: 3397 input + 394 output | 💰 **Cost**: ~$0.0268 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit bafa12972d into master 2026-08-16 02:16:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapShotcutRandomizer!13
No description provided.