cheapnud/CheapHelpers
Watch
1
0
Fork
You've already forked CheapHelpers
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge improved ProgressButton, add PageHeader and StatusChip #5

Merged
cheapnud merged 2 commits from d/component-mergeback into master 2026-08-17 11:37:32 +00:00
Conversation 1 Commits 2 Files changed 3 +113 -17
cheapnud commented 2026-08-17 11:31:12 +00:00
Owner
Copy link
No description provided.
merge improved ProgressButton, add PageHeader and StatusChip components
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 19s
Details
Build / Build and Test (pull_request) Successful in 2m22s
Details
3f5c731e0e
forgejo-actions commented 2026-08-17 11:31:33 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary
    Adds PageHeader and StatusChip components and improves ProgressButton with a re-entry guard and try/finally reset.

  2. Code Quality ⭐⭐⭐⭐☆
    Well-documented components; the re-entry guard and finally reset in ProgressButton are solid fixes.

  3. Issues
    🟢 ProgressButton.razor — Setting processing = false in finally without a StateHasChanged() should be fine here since it runs on the sync context after an await, but if OnClick completes synchronously (no real await) the UI may not reliably reflect the reset. Minor; verify behavior.

🟢 ProgressButton.razor — ButtonText is now dead when ChildContent is set, but the else branch (non-processing, non-ChildContent) isn't shown in the diff; confirm ButtonText still renders there.

  1. Verdict: APPROVE
    Clean, self-contained additions with a genuine reliability fix. No blocking issues.

📊 Tokens: 3328 input + 361 output | 💰 Cost: ~$0.0257
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Adds `PageHeader` and `StatusChip` components and improves `ProgressButton` with a re-entry guard and try/finally reset. 2. **Code Quality** ⭐⭐⭐⭐☆ Well-documented components; the re-entry guard and `finally` reset in ProgressButton are solid fixes. 3. **Issues** 🟢 ProgressButton.razor — Setting `processing = false` in `finally` without a `StateHasChanged()` should be fine here since it runs on the sync context after an await, but if `OnClick` completes synchronously (no real await) the UI may not reliably reflect the reset. Minor; verify behavior. 🟢 ProgressButton.razor — `ButtonText` is now dead when `ChildContent` is set, but the `else` branch (non-processing, non-ChildContent) isn't shown in the diff; confirm `ButtonText` still renders there. 4. **Verdict**: **APPROVE** Clean, self-contained additions with a genuine reliability fix. No blocking issues. --- 📊 **Tokens**: 3328 input + 361 output | 💰 **Cost**: ~$0.0257 *Generated by Claude Opus 4.8 via Gitea Actions*
default unmapped status colors instead of throwing
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 19s
Details
Build / Build and Test (pull_request) Successful in 2m30s
Details
cbad919a73
cheapnud merged commit 5a43105ed3 into master 2026-08-17 11:37:32 +00:00
cheapnud deleted branch d/component-mergeback 2026-08-17 11:37:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapHelpers!5
No description provided.