cheapnud/CheapHelpers
Watch
1
0
Fork
You've already forked CheapHelpers
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix missing DI registrations for localizer and reporting #3

Merged
cheapnud merged 1 commit from d/di-registration-fixes into master 2026-08-17 10:17:19 +00:00
Conversation 1 Commits 1 Files changed 3 +48 -2
cheapnud commented 2026-08-17 10:14:20 +00:00
Owner
Copy link
No description provided.
bump NuGet dependencies
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 13s
Details
Build / Build and Test (pull_request) Successful in 2m20s
Details
e53c84c2e2
register missing DI: non-generic IStringLocalizer and reporting exporters
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 12s
Details
Build / Build and Test (pull_request) Successful in 2m23s
Details
7b72452c4a
forgejo-actions commented 2026-08-17 10:14:33 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary — Adds missing DI registrations for the non-generic IStringLocalizer and the PDF/Excel exporters used by reporting, plus routine patch-level package bumps.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean, well-documented use of TryAdd to keep consumer overrides working; the fixes directly address real runtime resolution gaps.

  3. Issues

🟡 CheapHelpers.Services.csproj — Azure.AI.Translation.Document bumped 2.0.0 → 3.0.0 and Microsoft.Graph 6.2.0 → 6.5.0 are not patch-level bumps. The major version jump on Azure.AI.Translation is a potential breaking change; verify the consuming code still compiles/behaves correctly (this is out of scope for a PR titled "Fix missing DI registrations").

  1. Verdict: APPROVE

The DI fixes are correct and safe. Just confirm the Azure.AI.Translation.Document 3.0.0 major bump doesn't break existing translation code before merging.

📊 Tokens: 7625 input + 381 output | 💰 Cost: ~$0.0476
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** — Adds missing DI registrations for the non-generic `IStringLocalizer` and the PDF/Excel exporters used by reporting, plus routine patch-level package bumps. 2. **Code Quality** ⭐⭐⭐⭐☆ Clean, well-documented use of `TryAdd` to keep consumer overrides working; the fixes directly address real runtime resolution gaps. 3. **Issues** 🟡 CheapHelpers.Services.csproj — `Azure.AI.Translation.Document` bumped 2.0.0 → 3.0.0 and `Microsoft.Graph` 6.2.0 → 6.5.0 are not patch-level bumps. The major version jump on Azure.AI.Translation is a potential breaking change; verify the consuming code still compiles/behaves correctly (this is out of scope for a PR titled "Fix missing DI registrations"). 4. **Verdict**: **APPROVE** The DI fixes are correct and safe. Just confirm the `Azure.AI.Translation.Document` 3.0.0 major bump doesn't break existing translation code before merging. --- 📊 **Tokens**: 7625 input + 381 output | 💰 **Cost**: ~$0.0476 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit d8e1eaec81 into master 2026-08-17 10:17:19 +00:00
cheapnud deleted branch d/di-registration-fixes 2026-08-17 10:17:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapHelpers!3
No description provided.