Move NuGet publishing to forge Actions #1

Merged

cheapnud merged 1 commit from d/forge-publish into master

2026-08-09 20:29:32 +00:00

cheapnud commented

2026-08-09 20:26:38 +00:00

Owner

No description provided.

cheapnud added 1 commit

2026-08-09 20:26:38 +00:00

move NuGet publishing to forge Actions; drop redundant GitHub build/publish workflows

Claude PR Review / AI Code Review (pull_request) Successful in 15s

Details

Build / Build and Test (pull_request) Successful in 2m25s

Details

b889367c67

forgejo-actions commented

2026-08-09 20:26:54 +00:00

🤖 Claude AI Code Review

Summary
Migrates NuGet publishing from GitHub Actions to Gitea (forge) Actions, consolidating into a single tag-triggered workflow, plus TODO notes.
Code Quality ⭐⭐⭐⭐☆
Well-documented workflow with clear comments explaining the non-obvious Windows runner/UAC constraints.
Issues

🟡 publish.yml — publish-maui and publish-base publish independently but neither --skip-duplicate failure is caught. More importantly, the old workflow had || true on base pushes; the new base loop lets a single push failure fail the whole job, which may leave partial publishes (some base packages up, some not) and MediaProcessing gated behind it. Confirm this is the intended stricter behavior.

🟢 publish.yml — runs-on: windows (bare label) instead of windows-latest. Ensure a self-hosted runner is actually registered with the windows label, otherwise both MAUI and MediaProcessing jobs will hang unscheduled.

🟢 publish.yml — the 10-minute fixed Start-Sleep for NuGet indexing is fragile; if indexing is slower the MediaProcessing restore fails. Not new to this PR (carried from old workflow), so non-blocking.

Verdict: APPROVE

No blocking bugs, secret leaks, or breaking issues. Just confirm the self-hosted windows runner label exists before merging.

📊 Tokens: 7428 input + 512 output | 💰 Cost: ~$0.0499
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Migrates NuGet publishing from GitHub Actions to Gitea (forge) Actions, consolidating into a single tag-triggered workflow, plus TODO notes. 2. **Code Quality** ⭐⭐⭐⭐☆ Well-documented workflow with clear comments explaining the non-obvious Windows runner/UAC constraints. 3. **Issues** 🟡 publish.yml — `publish-maui` and `publish-base` publish independently but neither `--skip-duplicate` failure is caught. More importantly, the old workflow had `|| true` on base pushes; the new base loop lets a single push failure fail the whole job, which may leave partial publishes (some base packages up, some not) and MediaProcessing gated behind it. Confirm this is the intended stricter behavior. 🟢 publish.yml — `runs-on: windows` (bare label) instead of `windows-latest`. Ensure a self-hosted runner is actually registered with the `windows` label, otherwise both MAUI and MediaProcessing jobs will hang unscheduled. 🟢 publish.yml — the 10-minute fixed `Start-Sleep` for NuGet indexing is fragile; if indexing is slower the MediaProcessing restore fails. Not new to this PR (carried from old workflow), so non-blocking. 4. **Verdict**: **APPROVE** No blocking bugs, secret leaks, or breaking issues. Just confirm the self-hosted `windows` runner label exists before merging. --- 📊 **Tokens**: 7428 input + 512 output | 💰 **Cost**: ~$0.0499 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit 2292e03c4d into master

2026-08-09 20:29:32 +00:00

cheapnud deleted branch d/forge-publish

2026-08-09 20:29:32 +00:00

cheapnud referenced this pull request from a commit

2026-08-09 20:29:33 +00:00

Merge pull request 'Move NuGet publishing to forge Actions' (#1) from d/forge-publish into master