house style adoption

cheapnud commented

2026-08-17 14:56:58 +00:00

Owner

Adopts the shared design language across every page: flat themed chrome with aliased self-hosted fonts, page headers with module kickers, semantic status colors, progress buttons on async actions, uniform table plumbing, and a stronger conventions test suite. Also fixes a dozen latent dead controls found along the way.

cheapnud added 11 commits

2026-08-17 14:56:58 +00:00

add the app theme with aliased fonts and flat chrome 69a108ee1a

add page header progress button and status chip components 65f8b0af87

remap status colors to the semantic scheme e73668a1a9

restyle the business core pages to the house anatomy 8d985354cc

finish the table plumbing on the business core pages 926c0f29ad

restyle the supply and logistics pages ecfce4370a

restyle the studio and system pages c598ee2c38

restyle the planner pages 1f14213104

enforce the house style conventions 6314cd2fe3

polish the house style edges from review 8e13c8fd27

wire the remaining switches and scrub stray references

Claude PR Review / AI Code Review (pull_request) Successful in 19s

Details

Build & Test / Build and Test (pull_request) Successful in 7m36s

Details

2b0a405649

forgejo-actions commented

2026-08-17 14:57:18 +00:00

🤖 Claude AI Code Review

Summary
Large but disciplined house-style sweep introducing shared PageHeader/StatusChip/ProgressButton components, a centralized theme, and a strong grep-based conventions test suite; also fixes real dead @bind-Checked switches.
Code Quality ⭐⭐⭐⭐☆
Excellent test coverage and genuinely well-documented rationale; the @bind-Checked→@bind-Value fix and its regression guard are especially good.
Issues

🟡 ProgressButton.razor — StartIcon is dropped while running but the spinner has Class="mr-2" even when ChildContent is null (icon-only usage). Minor visual only; not a bug in behavior. (Skip if intentional.)

🟢 PageHeader.razor — the .mud-text-secondary class on the kicker and Subtitle body2 rely on MudBlazor emitting that utility class; the conventions test checks mud-typography-overline instead, so this is fine, but worth confirming mud-text-secondary actually exists in your MudBlazor version (it's mud-secondary-text in some versions).

🟢 UiConventionsTests — HexColorPattern (#[0-9A-Fa-f]{3,8}) will match things like Git-style refs or #region-adjacent text inside razor markup/comments, risking false positives on future edits. Low risk given current allowlist, but the heuristic is broad.

Verdict: APPROVE

The switch-binding fixes are real, correct, and now guarded against regression. No blocking bugs, security issues, deadlocks, or resource leaks found. The loading-flag try/finally refactors are correct and the search/filter additions are pure client-side over already-loaded lists.

📊 Tokens: 138699 input + 615 output | 💰 Cost: ~$0.7089
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Large but disciplined house-style sweep introducing shared PageHeader/StatusChip/ProgressButton components, a centralized theme, and a strong grep-based conventions test suite; also fixes real dead `@bind-Checked` switches. 2. **Code Quality** ⭐⭐⭐⭐☆ Excellent test coverage and genuinely well-documented rationale; the `@bind-Checked`→`@bind-Value` fix and its regression guard are especially good. 3. **Issues** 🟡 ProgressButton.razor — `StartIcon` is dropped while running but the spinner has `Class="mr-2"` even when `ChildContent` is null (icon-only usage). Minor visual only; not a bug in behavior. (Skip if intentional.) 🟢 PageHeader.razor — the `.mud-text-secondary` class on the kicker and `Subtitle` `body2` rely on MudBlazor emitting that utility class; the conventions test checks `mud-typography-overline` instead, so this is fine, but worth confirming `mud-text-secondary` actually exists in your MudBlazor version (it's `mud-secondary-text` in some versions). 🟢 UiConventionsTests — `HexColorPattern` (`#[0-9A-Fa-f]{3,8}`) will match things like Git-style refs or `#region`-adjacent text inside razor markup/comments, risking false positives on future edits. Low risk given current allowlist, but the heuristic is broad. 4. **Verdict**: **APPROVE** The switch-binding fixes are real, correct, and now guarded against regression. No blocking bugs, security issues, deadlocks, or resource leaks found. The loading-flag `try/finally` refactors are correct and the search/filter additions are pure client-side over already-loaded lists. --- 📊 **Tokens**: 138699 input + 615 output | 💰 **Cost**: ~$0.7089 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit d1e9b78afa into master

2026-08-17 15:05:06 +00:00

cheapnud referenced this pull request from a commit

2026-08-17 15:05:06 +00:00

Merge pull request 'house style adoption' (#6) from d/ux2-house-style into master

Rows
Columns

house style adoption #6

🤖 Claude AI Code Review