reorder point mrp

cheapnud commented

2026-08-17 01:42:35 +00:00

Owner

Adds material planning profiles and supplier terms with prices, a movement log feeding computed usage, reorder suggestions with moq and package rounding that fire with or without demand, order-by dates, and per-preferred-supplier draft creation with price snapshots.

cheapnud added 10 commits

2026-08-17 01:42:35 +00:00

log every material stock movement c479d237e4

add material planning profiles and supplier terms a3fda81e0a

plan reorder suggestions from profiles terms and usage dbbfeb8a50

group material orders by preferred supplier with price snapshots c3cd5212a2

make the preferred supplier draft batch atomic 69f89c955e

edit material profiles terms and movements from the stock tab 2638c00543

route the preferred chip through status colors efc303ad61

surface reorder planning on the forecast tab 2e336cf51b

tick the mrp ledger 568056e4fb

fire reorder points without demand and guard supplier deletes

Claude PR Review / AI Code Review (pull_request) Successful in 16s

Details

Build & Test / Build and Test (pull_request) Successful in 7m32s

Details

6b39ac76ed

forgejo-actions commented

2026-08-17 01:42:51 +00:00

🤖 Claude AI Code Review

Summary
Adds MRP reorder-point planning (profiles, supplier terms, movement log, priced drafts) with extensive tests. Cohesive, well-documented, and correctly batched.
Code Quality ⭐⭐⭐⭐⭐
Excellent atomicity discipline (single-SaveChanges batching, movement rows written in the same transaction as stock mutations) and thorough test coverage of edge cases.
Issues

🟢 MaterialNeedsService.cs — consumptionMovements loads the entire Backflush/BackflushUndo history unwindowed into memory before filtering by windowStart. This is already acknowledged in TODO.md as an upgrade path; fine for now but will grow unbounded over time.

🟢 MaterialsPage.razor — In CreateOrderAsync, when the fallback dialog is canceled, stillUnassigned stays >0 and the snackbar reports remaining rows correctly, but a batch that created some grouped drafts plus a canceled fallback still shows a Warning. Minor UX nit, not a bug.

Verdict: APPROVE

Movement-write atomicity, price snapshotting, the preferred-term invariant, and the supplier delete-guard extension are all handled correctly and well-tested. The one known scaling concern is already tracked.

📊 Tokens: 114392 input + 465 output | 💰 Cost: ~$0.5836
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Adds MRP reorder-point planning (profiles, supplier terms, movement log, priced drafts) with extensive tests. Cohesive, well-documented, and correctly batched. 2. **Code Quality** ⭐⭐⭐⭐⭐ Excellent atomicity discipline (single-SaveChanges batching, movement rows written in the same transaction as stock mutations) and thorough test coverage of edge cases. 3. **Issues** 🟢 `MaterialNeedsService.cs` — `consumptionMovements` loads the entire Backflush/BackflushUndo history unwindowed into memory before filtering by `windowStart`. This is already acknowledged in TODO.md as an upgrade path; fine for now but will grow unbounded over time. 🟢 `MaterialsPage.razor` — In `CreateOrderAsync`, when the fallback dialog is canceled, `stillUnassigned` stays >0 and the snackbar reports remaining rows correctly, but a batch that created some grouped drafts plus a canceled fallback still shows a Warning. Minor UX nit, not a bug. 4. **Verdict**: **APPROVE** Movement-write atomicity, price snapshotting, the preferred-term invariant, and the supplier delete-guard extension are all handled correctly and well-tested. The one known scaling concern is already tracked. --- 📊 **Tokens**: 114392 input + 465 output | 💰 **Cost**: ~$0.5836 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit bc6f4561fc into master

2026-08-17 01:50:35 +00:00

cheapnud referenced this pull request from a commit

2026-08-17 01:50:37 +00:00

Merge pull request 'reorder point mrp' (#5) from d/sp3-mrp into master

Rows
Columns

reorder point mrp #5

🤖 Claude AI Code Review