in-house material needs #3

Merged

cheapnud merged 11 commits from d/sp2-materials into master 2026-08-12 01:57:08 +00:00

Conversation 1 Commits 11 Files changed 70 +6030 -122

cheapnud commented 2026-08-12 01:49:34 +00:00

Owner

Copy link

Splits production per model into in-house and outsourced, adds a bom-driven material forecast with stock and material purchase orders with partial receipts, and a finishing scan that backflushes stock symmetrically with undo.

Splits production per model into in-house and outsourced, adds a bom-driven material forecast with stock and material purchase orders with partial receipts, and a finishing scan that backflushes stock symmetrically with undo.

cheapnud added 11 commits 2026-08-12 01:49:34 +00:00

resolve per-unit material requirements through the pricing resolve stage 128e812633

rename fabric material kind to avoid enum name clash 6f2cd1f9ef

add material stock and order tables with an in-house model marker 1d1f9ac9b3

compute in-house material needs with stock and on-order context 87af276336

resolve fabric display names in the material forecast bd0c57f2f6

add material purchase orders with partial receipts into stock dc8f59696c

finish in-house units with symmetric material backflush 8dc7030b6a

add materials page with forecast stock and order surfaces 451fc2f1cf

add finishing page and in-house model marking 26c8217684

guard the finish and receive paths and require positive order quantities b2fd4ab3c6

ledger materials audit notes 4a4063a937

forgejo-actions commented 2026-08-12 01:49:53 +00:00

Copy link

🤖 Claude AI Code Review

1. Summary

Adds in-house material forecasting, material purchase orders with partial receipts, and a finishing scan that backflushes stock symmetrically. Well-structured, heavily tested, mirrors existing purchasing patterns.

2. Code Quality

⭐⭐⭐⭐⭐

Exceptional test coverage and thoughtful invariant documentation; the three-state resolution rule (dropship/mapped/in-house/unresolved) is consistently enforced across sweep, forecast, and finish paths, and the backflush symmetry regression tests are thorough.

3. Issues

🟢 MaterialOrderService.ReceiveAsync / ProductionUnitService.ApplyBackflushAsync — Stock upsert reads-then-writes without a unique-constraint retry. Two concurrent receipts/finishes for the same (Kind, Code, HardnessCode) could both find stock is null, insert two rows, and hit the unique index on the second SaveChanges. Given the desktop/single-writer nature of this app this is likely acceptable, but worth confirming the concurrency model.

🟢 MaterialNeedsService.ComputeAsync — Units on in-house lines with a null PinnedCatalogueVersion are silently dropped (the group.Key is null guard), whereas ApplyBackflushAsync throws on the same condition. This divergence is already self-flagged in TODO.md, so no action needed beyond acknowledging it's tracked.

4. Verdict

APPROVE

The MaterialKind enum split from FabricMaterialKind is a clean breaking rename handled consistently, the new migration matches the model, and role gating/tests are solid. The two issues above are minor and (for concurrency) likely out of scope given the app's single-user desktop model.

---

📊 Tokens: 149031 input + 624 output | 💰 Cost: ~$0.7608
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review ## 1. Summary Adds in-house material forecasting, material purchase orders with partial receipts, and a finishing scan that backflushes stock symmetrically. Well-structured, heavily tested, mirrors existing purchasing patterns. ## 2. Code Quality ⭐⭐⭐⭐⭐ Exceptional test coverage and thoughtful invariant documentation; the three-state resolution rule (dropship/mapped/in-house/unresolved) is consistently enforced across sweep, forecast, and finish paths, and the backflush symmetry regression tests are thorough. ## 3. Issues 🟢 `MaterialOrderService.ReceiveAsync` / `ProductionUnitService.ApplyBackflushAsync` — Stock upsert reads-then-writes without a unique-constraint retry. Two concurrent receipts/finishes for the same `(Kind, Code, HardnessCode)` could both find `stock is null`, insert two rows, and hit the unique index on the second `SaveChanges`. Given the desktop/single-writer nature of this app this is likely acceptable, but worth confirming the concurrency model. 🟢 `MaterialNeedsService.ComputeAsync` — Units on in-house lines with a null `PinnedCatalogueVersion` are silently dropped (the `group.Key is null` guard), whereas `ApplyBackflushAsync` throws on the same condition. This divergence is already self-flagged in TODO.md, so no action needed beyond acknowledging it's tracked. ## 4. Verdict **APPROVE** The `MaterialKind` enum split from `FabricMaterialKind` is a clean breaking rename handled consistently, the new migration matches the model, and role gating/tests are solid. The two issues above are minor and (for concurrency) likely out of scope given the app's single-user desktop model. --- 📊 **Tokens**: 149031 input + 624 output | 💰 **Cost**: ~$0.7608 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit 7ca22f06b5 into master 2026-08-12 01:57:08 +00:00

cheapnud referenced this pull request from a commit 2026-08-12 01:57:09 +00:00

Merge pull request 'in-house material needs' (#3) from d/sp2-materials into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

cheapnud/CheapFurniturePlanner!3

No description provided.