catalogue export #2

Merged

cheapnud merged 5 commits from d/xc1-export into master 2026-08-10 14:29:39 +00:00

Conversation 1 Commits 5 Files changed 9 +621 -5

cheapnud commented 2026-08-10 14:22:00 +00:00

Owner

Copy link

Adds a flat csv price list and a verbatim json bundle export per published catalogue version, generated from the price versions page.

Adds a flat csv price list and a verbatim json bundle export per published catalogue version, generated from the price versions page.

cheapnud added 5 commits 2026-08-10 14:22:00 +00:00

flatten published catalogues to price list rows d226529758

export published catalogues as csv price list and json bundle 1a66fad4f1

add catalogue export actions to the price versions page bef009edff

honor authored defaults in the export flattener and export any published version 8fcf0bab7a

ledger export audit notes 5cac80092d

forgejo-actions commented 2026-08-10 14:22:13 +00:00

Copy link

🤖 Claude AI Code Review

1. Summary
   Adds a CatalogueExport service producing a flat CSV price list and verbatim JSON bundle per published catalogue version, wired into the price versions page, backed by a well-tested CatalogueFlattener.

2. Code Quality ⭐⭐⭐⭐⭐
   Excellent test coverage that verifies exported prices agree with the actual pricing engine, plus byte-identical JSON round-trip guarantees.

3. Issues

🟢 CatalogueExport.cs — The CSV price uses "0.00" hard-rounding while CatalogueRow.Price may already carry the engine's rounded value; this is already acknowledged in TODO.md as a known audit item, so not blocking.

4. Verdict: APPROVE

Clean, well-scoped, and thoroughly tested. Known limitations are documented in TODO.md rather than left silent.

---

📊 Tokens: 16665 input + 311 output | 💰 Cost: ~$0.0911
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Adds a `CatalogueExport` service producing a flat CSV price list and verbatim JSON bundle per published catalogue version, wired into the price versions page, backed by a well-tested `CatalogueFlattener`. 2. **Code Quality** ⭐⭐⭐⭐⭐ Excellent test coverage that verifies exported prices agree with the actual pricing engine, plus byte-identical JSON round-trip guarantees. 3. **Issues** 🟢 CatalogueExport.cs — The CSV price uses `"0.00"` hard-rounding while `CatalogueRow.Price` may already carry the engine's rounded value; this is already acknowledged in TODO.md as a known audit item, so not blocking. 4. **Verdict**: **APPROVE** Clean, well-scoped, and thoroughly tested. Known limitations are documented in TODO.md rather than left silent. --- 📊 **Tokens**: 16665 input + 311 output | 💰 **Cost**: ~$0.0911 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit 5c424a81c6 into master 2026-08-10 14:29:39 +00:00

cheapnud referenced this pull request from a commit 2026-08-10 14:29:41 +00:00

Merge pull request 'catalogue export' (#2) from d/xc1-export into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

cheapnud/CheapFurniturePlanner!2

No description provided.