cheapnud/CheapClerk
Watch
1
0
Fork
You've already forked CheapClerk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Give every page the house header anatomy #9

Merged
cheapnud merged 1 commit from d/style-anatomy into master 2026-08-17 00:23:10 +00:00
Conversation 1 Commits 1 Files changed 10 +70 -35
cheapnud commented 2026-08-17 00:20:30 +00:00
Owner
Copy link

Shared PageHeader (kicker, title, subtitle, right-aligned actions) applied to all pages; the document page moves share/edit/delete into the header actions and shows the correspondent as subtitle.

Shared PageHeader (kicker, title, subtitle, right-aligned actions) applied to all pages; the document page moves share/edit/delete into the header actions and shows the correspondent as subtitle.
Give every page the house header anatomy
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 11s
Details
Build & Test / Build and Test (pull_request) Successful in 2m24s
Details
5c51d4307d
forgejo-actions commented 2026-08-17 00:20:41 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary: Introduces a shared PageHeader component and applies consistent header anatomy across all pages, moving document actions into the header.

  2. Code Quality: ⭐⭐⭐⭐⭐
    Clean, well-factored shared component with sensible parameters and consistent adoption.

  3. Issues

🟢 DocumentDetail.razor — The old edit/delete/share block was guarded by @if (!_isEditing), hiding actions during editing. The new header actions are always shown; Edit is now disabled via Disabled="_isEditing", but Share and Delete remain active while editing. Verify that's intended behavior (e.g. deleting/sharing mid-edit).

  1. Verdict: APPROVE

Minor behavioral change worth a quick confirmation, but nothing blocking.

📊 Tokens: 6295 input + 284 output | 💰 Cost: ~$0.0386
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary**: Introduces a shared `PageHeader` component and applies consistent header anatomy across all pages, moving document actions into the header. 2. **Code Quality**: ⭐⭐⭐⭐⭐ Clean, well-factored shared component with sensible parameters and consistent adoption. 3. **Issues** 🟢 DocumentDetail.razor — The old edit/delete/share block was guarded by `@if (!_isEditing)`, hiding actions during editing. The new header actions are always shown; Edit is now disabled via `Disabled="_isEditing"`, but Share and Delete remain active while editing. Verify that's intended behavior (e.g. deleting/sharing mid-edit). 4. **Verdict**: **APPROVE** Minor behavioral change worth a quick confirmation, but nothing blocking. --- 📊 **Tokens**: 6295 input + 284 output | 💰 **Cost**: ~$0.0386 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit 027696e646 into master 2026-08-17 00:23:10 +00:00
cheapnud deleted branch d/style-anatomy 2026-08-17 00:23:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapClerk!9
No description provided.