Prune superseded images on deploy #3

Merged

cheapnud merged 1 commit from b/prune-old-images into master 2026-08-15 13:26:44 +00:00

Conversation 1 Commits 1 Files changed 1 +3 -1

cheapnud commented 2026-08-15 13:23:59 +00:00

Owner

Copy link

No description provided.

cheapnud added 1 commit 2026-08-15 13:23:59 +00:00

Prune superseded images on deploy 4829242859

forgejo-actions commented 2026-08-15 13:24:12 +00:00

Copy link

🤖 Claude AI Code Review

1. Summary Changes docker image prune -f to -a -f to remove old version-tagged images that never become dangling.

2. Code Quality ⭐⭐⭐⭐☆
   Well-documented change with a clear rationale in the comment.

3. Issues

🟡 deploy.yml — docker image prune -a -f removes all images not used by a running container, not just superseded ones. If this runs immediately after docker compose up -d, images for services that are momentarily stopped/restarting, or shared base images pulled for future use, can be removed—forcing re-pulls. More importantly, if the compose stack references images by tag that aren't currently running (e.g. sidecars started on-demand), they'll be purged. Verify all needed images are attached to running containers at prune time.

4. Verdict: APPROVE

The change addresses a real disk-fill problem and is low-risk given the prune runs after the stack is recreated. Confirm no on-demand/sidecar images are unintentionally purged.

---

📊 Tokens: 1007 input + 343 output | 💰 Cost: ~$0.0136
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Changes `docker image prune -f` to `-a -f` to remove old version-tagged images that never become dangling. 2. **Code Quality** ⭐⭐⭐⭐☆ Well-documented change with a clear rationale in the comment. 3. **Issues** 🟡 deploy.yml — `docker image prune -a -f` removes *all* images not used by a running container, not just superseded ones. If this runs immediately after `docker compose up -d`, images for services that are momentarily stopped/restarting, or shared base images pulled for future use, can be removed—forcing re-pulls. More importantly, if the compose stack references images by tag that aren't currently running (e.g. sidecars started on-demand), they'll be purged. Verify all needed images are attached to running containers at prune time. 4. **Verdict**: **APPROVE** The change addresses a real disk-fill problem and is low-risk given the prune runs after the stack is recreated. Confirm no on-demand/sidecar images are unintentionally purged. --- 📊 **Tokens**: 1007 input + 343 output | 💰 **Cost**: ~$0.0136 *Generated by Claude Opus 4.8 via Gitea Actions*

cheapnud merged commit 147ce71679 into master 2026-08-15 13:26:44 +00:00

cheapnud deleted branch b/prune-old-images 2026-08-15 13:26:44 +00:00

cheapnud referenced this pull request from a commit 2026-08-15 13:26:45 +00:00

Prune superseded images on deploy (#3)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

cheapnud/CheapClerk!3

No description provided.