cheapnud/CheapClerk
Watch
1
0
Fork
You've already forked CheapClerk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move the queue count into the drawer #16

Merged
cheapnud merged 1 commit from b/queue-indicator into master 2026-08-17 23:59:25 +00:00
Conversation 1 Commits 1 Files changed 3 +12 -5
cheapnud commented 2026-08-17 23:56:45 +00:00
Owner
Copy link
No description provided.
Move the queue count into the drawer
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 12s
Details
Build & Test / Build and Test (pull_request) Successful in 2m28s
Details
829d9837f9
forgejo-actions commented 2026-08-17 23:56:57 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary — Moves the queue count from a header badge into a chip on the drawer's Queue nav link, and swaps the header to an indicator icon with a localized tooltip.

  2. Code Quality ⭐⭐⭐⭐☆
    Both resource files are kept in sync with the new localization key.

  3. Issues

🟢 MainLayout.razor — QueueProcessingHint uses a {0} placeholder, so Loc["QueueProcessingHint", _activeTaskCount] requires the localizer's params overload to actually format it. Confirm Loc supports the [string, params object[]] indexer (the existing badge used Content="_activeTaskCount", so this formatting pattern is new here); otherwise the literal {0} will render.

  1. Verdict: APPROVE

Verify the Loc[key, args] formatting overload works as expected before merging, but no blocking issues.

📊 Tokens: 2342 input + 320 output | 💰 Cost: ~$0.0197
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** — Moves the queue count from a header badge into a chip on the drawer's Queue nav link, and swaps the header to an indicator icon with a localized tooltip. 2. **Code Quality** ⭐⭐⭐⭐☆ Both resource files are kept in sync with the new localization key. 3. **Issues** 🟢 MainLayout.razor — `QueueProcessingHint` uses a `{0}` placeholder, so `Loc["QueueProcessingHint", _activeTaskCount]` requires the localizer's params overload to actually format it. Confirm `Loc` supports the `[string, params object[]]` indexer (the existing badge used `Content="_activeTaskCount"`, so this formatting pattern is new here); otherwise the literal `{0}` will render. 4. **Verdict**: **APPROVE** Verify the `Loc[key, args]` formatting overload works as expected before merging, but no blocking issues. --- 📊 **Tokens**: 2342 input + 320 output | 💰 **Cost**: ~$0.0197 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit 74066990b7 into master 2026-08-17 23:59:25 +00:00
cheapnud deleted branch b/queue-indicator 2026-08-17 23:59:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapClerk!16
No description provided.