cheapnud/CheapClerk
Watch
1
0
Fork
You've already forked CheapClerk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stamp the release version into the image #15

Merged
cheapnud merged 1 commit from b/version-buildarg into master 2026-08-17 23:13:33 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
cheapnud commented 2026-08-17 23:10:53 +00:00
Owner
Copy link
No description provided.
Stamp the release version into the image
All checks were successful
Claude PR Review / AI Code Review (pull_request) Successful in 11s
Details
Build & Test / Build and Test (pull_request) Successful in 2m23s
Details
f91abe5f98
forgejo-actions commented 2026-08-17 23:11:05 +00:00
Copy link

🤖 Claude AI Code Review

  1. Summary
    Adds --build-arg APP_VERSION to the docker build command to stamp the release version into the image.

  2. Code Quality ⭐⭐⭐⭐☆
    Minimal, focused change using a clean parameter expansion to strip the v prefix.

  3. Issues

🟡 deploy.yml — ${TAG} variable not visible in diff. Confirm TAG is defined/exported earlier in this step (and that the Dockerfile declares an ARG APP_VERSION before its use), otherwise the build arg will resolve to empty.

  1. Verdict: APPROVE

Assuming TAG is set elsewhere in the workflow and the Dockerfile has a matching ARG APP_VERSION, this is good to merge.

📊 Tokens: 1016 input + 272 output | 💰 Cost: ~$0.0119
Generated by Claude Opus 4.8 via Gitea Actions

## 🤖 Claude AI Code Review 1. **Summary** Adds `--build-arg APP_VERSION` to the docker build command to stamp the release version into the image. 2. **Code Quality** ⭐⭐⭐⭐☆ Minimal, focused change using a clean parameter expansion to strip the `v` prefix. 3. **Issues** 🟡 deploy.yml — `${TAG}` variable not visible in diff. Confirm `TAG` is defined/exported earlier in this step (and that the Dockerfile declares an `ARG APP_VERSION` before its use), otherwise the build arg will resolve to empty. 4. **Verdict**: **APPROVE** Assuming `TAG` is set elsewhere in the workflow and the Dockerfile has a matching `ARG APP_VERSION`, this is good to merge. --- 📊 **Tokens**: 1016 input + 272 output | 💰 **Cost**: ~$0.0119 *Generated by Claude Opus 4.8 via Gitea Actions*
cheapnud merged commit 5615b58dda into master 2026-08-17 23:13:33 +00:00
cheapnud deleted branch b/version-buildarg 2026-08-17 23:13:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
cheapnud/CheapClerk!15
No description provided.