Show only narrowed track selections on queue cards #28
Loading…
Reference in a new issue
No description provided.
Delete branch "d/queue-selected-tracks"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A job that keeps every track no longer stores the full track list, so the queue card track chip only appears when tracks were actually narrowed. Rendering is unchanged (all-selected and null behave identically).
🤖 Claude AI Code Review
Summary: Stores narrowed track selections only, treating "all selected" as null so the queue card chip appears only when tracks were actually narrowed.
Code Quality ⭐⭐⭐⭐☆
Clear intent, well-documented rationale, minimal and focused change.
Issues
🟡 AddRenderJob.razor — Verify
ApplyTrackSelectiontruly treats null and full-list identically. The correctness of this change hinges entirely on that assumption. If any downstream consumer (e.g. rendering with a subset of available-but-not-selected-vs-all logic) distinguishes null from an explicit full list, this silently drops track filtering. Confirm this holds.🟢 AddRenderJob.razor — If
selectedVideoIndicescan contain a subset that equals_videoTracks.Countbut with different indices (e.g. duplicates or stale indices), the.Length < .Countguard would misclassify. Unlikely given the.Selectsource, but worth a sanity check.The change is small, well-reasoned, and self-consistent given the stated behavior of
ApplyTrackSelection. Just confirm the null-equals-all assumption once before merge.📊 Tokens: 1234 input + 426 output | 💰 Cost: ~$0.0168
Generated by Claude Opus 4.8 via Gitea Actions